[Logo] Jaikoz and SongKong Forums
  [Search] Search   [Recent Topics] Recent Topics   [Members]  Member Listing   [Groups] Back to home page 
[Register] Register / 
[Login] Login 
SongKong 3.9 Issues  XML
Forum Index -> SongKong Issues
Author Message
chillware

Pro

Joined: 17/11/2010 13:13:39
Messages: 99
Offline

First of thanks for another great update! Lots of needed improvements and it's matching albums from my unsorted albums better than ever! SK is an amazing application!

However, so far I've run across two issues that I don't think should be..

First, since 3.9, many of my DJ Mixed albums are now getting tagged as VA instead of by the DJ Mixer as they had in previous versions. An example album would be DJ Dan - Loose Caboose is now VA - Loose Caboose, also DJ Dan - In Stereo is now VA - In Stereo. I believe 3.8 tagged these correctly.

Secondly, multidisc matching is vastly improved, however on occasion SK will move all discs in to a single folder (as expected) and other times it'll move each disc to it's own folder 'Album - (disc 1) & Album - (disc 2). I'm guessing this has something to do w/ the way you are now checking for multidisc since 3.8 and which source SK found the album in.

If need be I can provide files/support, not sure if you need them. Let me know.

Thanks!!
paultaylor

Pro
[Avatar]

Joined: 21/08/2006 09:21:27
Messages: 7483
Online

Hi, yes would be easier and quicker for me to fix if you could send me files and support files.

thanks Paul (Administrator)
chillware

Pro

Joined: 17/11/2010 13:13:39
Messages: 99
Offline

Here is one album in particular that is exhibiting all of the unwanted

It should match to: http://www.discogs.com/Dieselboy-The-Dungeonmasters-Guide/master/73242

Issues:
1. SK won't match this multi-disc album unless all the files are in one folder, however it saves the two discs in separate folders. If you try to re-run these two folders back through SK, it fails to find a match. I have noticed SK is failing to match A LOT of albums now that are separated in to multiple folders... something is def wrong here. Conversely, I have noticed a few multidisc albums with all files in 1 folder that SK wont match either, I'm pretty sure SK 3.8 did match these without issue.

2. This album also gets renamed as VA, it should not - Dieselboy is the album artist. Since SK 3.9, A LOT, if not all DJ Mixed or compilation albums are getting marked as VA instead of the album artist. SK 3.8 did not do this. I can provide more albums if needed.

3. Not directly related to this album, but SK 3.9 is leaving behind random tracks after it moves an album.. It leaves 1, 2, 3 or even more random tracks in the original folder/location. It does move the complete album to the new location though, just doesn't completely clean up the old location. This is new and has only started in 3.9. - If I run an undo after noticing this problem, it does move the album back, but the random tracks it left behind are now duplicated. Thus making for a biiig mess.
chillware

Pro

Joined: 17/11/2010 13:13:39
Messages: 99
Offline

Yeah, I'll be able to get more albums /support files to you probably in a couple of days, I was hoping the album I linked above would at least get you started. Thanks!
paultaylor

Pro
[Avatar]

Joined: 21/08/2006 09:21:27
Messages: 7483
Online

Oh you saw that message, sorry I didn't see your link when I did I deleted that message - I shall look at it today.

thanks Paul (Administrator)
paultaylor

Pro
[Avatar]

Joined: 21/08/2006 09:21:27
Messages: 7483
Online

chillware wrote:

Issues:
1. SK won't match this multi-disc album unless all the files are in one folder, however it saves the two discs in separate folders. If you try to re-run these two folders back through SK, it fails to find a match.
 

Okay the problem with this album is that is the files are in multiple folders and they contain duplicates files, the first folder contains three duplicates. So if you have Only allow Match if all tracks in album were matched SongKong first tries to match all 27 tracks to one album (impossible - too many tracks for album), then all 27 tracks to Discogs (impossible - too many tracks for album) then folder 1 (21 tracks to one album - impossible incomplete) and so on.

If you had done either of the these 3 things

Disabled Only allow Match if all tracks in album were matched
or
Delete the DUplicates
or
Put the songs in one folder

it would have worked

chillware wrote:

I have noticed SK is failing to match A LOT of albums now that are separated in to multiple folders... something is def wrong here. Conversely, I have noticed a few multidisc albums with all files in 1 folder that SK wont match either, I'm pretty sure SK 3.8 did match these without issue.
 

But thankyou I have found a regression http://jthink.net:8081/browse/SONGKONG-826 caused by http://jthink.net:8081/browse/SONGKONG-805 fix for SongKong 3.9 - I think this is the main issue

chillware wrote:

2. This album also gets renamed as VA, it should not - Dieselboy is the album artist. Since SK 3.9, A LOT, if not all DJ Mixed or compilation albums are getting marked as VA instead of the album artist. SK 3.8 did not do this. I can provide more albums if needed.
 

Right I'm not seeing that issue, its no Various Artist but it is a Compilation so could it just be what you have your Compilation Rename Mask set to.

chillware wrote:

3. Not directly related to this album, but SK 3.9 is leaving behind random tracks after it moves an album.. It leaves 1, 2, 3 or even more random tracks in the original folder/location. It does move the complete album to the new location though, just doesn't completely clean up the old location. This is new and has only started in 3.9. - If I run an undo after noticing this problem, it does move the album back, but the random tracks it left behind are now duplicated. Thus making for a biiig mess. 

I think this is again caused by http://jthink.net:8081/browse/SONGKONG-826.

Due to the impact of this issue I intend to have a new release out by tommorrow at the latest.

thanks Paul (Administrator)
paultaylor

Pro
[Avatar]

Joined: 21/08/2006 09:21:27
Messages: 7483
Online

SongKong 3.10 now released - I believe this will fix your issues, if not of course let me know.

thanks Paul (Administrator)
chillware

Pro

Joined: 17/11/2010 13:13:39
Messages: 99
Offline

Great - 3.10 is working much better now!

Can you help me to understand why SK won't match this album?

Jaikoz can match it to both MB and Discogs, SK refuses. I have't tried putting both CDs in one folder, my guess is that it would work, but I'm trying to get the multi folder thing figured out still..

http://www.discogs.com/DJ-Dan-Lift/release/958387
https://musicbrainz.org/release/751351bf-a158-4f13-86d3-c5dd50f85f06

Thanks for all the hard work, I really appreciate that and your awesome support!

paultaylor

Pro
[Avatar]

Joined: 21/08/2006 09:21:27
Messages: 7483
Online

Hi, gosh you kep't me busy today - but its led to some nice improvements so thankyou.


Okay assuming you have Only Allow match if All Songs Matched and Only Allow Match if all tracks on album matched the problem is that although SongKong considers the two subfolder as being part of one release it does an additional check based on name to confirm this, and that check is is case-sensitive so I search for cd but doesn't match CD so then it trys to match each folder in turn and of course cannot find a 14 track match for each folder. Raised issue http://jthink.net:8081/browse/SONGKONG-831

But before I found that problem I unchecked Only Allow Match if all tracks on album matched and couldn't understand why it then could match each folder in turn incompletely to the correct release and this lead to these issues:

http://jthink.net:8081/browse/SONGKONG-829
http://jthink.net:8081/browse/SONGKONG-830

and whilst working that out I wondered why song only matching didn't work, leading to :

http://jthink.net:8081/browse/SONGKONG-828

All these fixed for next release

I then wondered why the Discogs release didn't match, this is because the

http://www.discogs.com/DJ-Dan-Lift/release/958387

release seems to have 29 tracks, its unclear to me whether the first track is a real track or not, and unfortunately the way Discogs makes the data available doesn't make it clear either. If Only Allow Match if all tracks on album matched is disabled then it can be matched

thanks Paul (Administrator)
chillware

Pro

Joined: 17/11/2010 13:13:39
Messages: 99
Offline

Awesome! Can't wait! Sorry, didn't intend to keep you so busy, lol!
paultaylor

Pro
[Avatar]

Joined: 21/08/2006 09:21:27
Messages: 7483
Online

Hi, all should be fixed in SongKong 3.11 http://blog.jthink.net/2015/02/improved-song-matching-with-songkong-311.html

thanks Paul (Administrator)
chillware

Pro

Joined: 17/11/2010 13:13:39
Messages: 99
Offline

Hello! 3.11 is working fantastically. Much better at matching the multi folder albums now, and now with the MBID/Discogs URL being looked at, it's matched many 100's of albums that previous versions missed. Thank you so much for being absolutely amazing!

However.. Running in to another issue.. It looks like SK 3.11 is matching and moving incomplete albums even though the option to "only allow match if all tracks in album were matched" is checked. I also have the option "only allow match if all songs in grouping match to one album" checked.


Thank you!!
paultaylor

Pro
[Avatar]

Joined: 21/08/2006 09:21:27
Messages: 7483
Online

Ah, its a regression:

http://jthink.net:8081/browse/SONGKONG-837
http://jthink.net:8081/browse/SONGKONG-838

when we consider existing MusicBrainz and Discogs ids we are not checking that they are valid matches based on trackcount and user options, specifically not taking into account the Only allow match if all tracks on album were matched option.


thanks Paul (Administrator)
paultaylor

Pro
[Avatar]

Joined: 21/08/2006 09:21:27
Messages: 7483
Online

Now fixed in 3.12

thanks Paul (Administrator)
paultaylor

Pro
[Avatar]

Joined: 21/08/2006 09:21:27
Messages: 7483
Online

Sorry its fixed for MusicBrainz matching but there was a bug in the Discogs fix, http://jthink.net:8081/browse/SONGKONG-838 now properly fixed for SongKong 3.13

thanks Paul (Administrator)
paultaylor

Pro
[Avatar]

Joined: 21/08/2006 09:21:27
Messages: 7483
Online

Okay SongKong 3.13 now released.

thanks Paul (Administrator)
 
Forum Index -> SongKong Issues
Go to:   
Powered by JForum 2.1.6 © JForum Team