PMD Results

The following document contains the results of PMD 4.2.2.

Files

org/jaudiotagger/audio/asf/io/AsfExtHeaderModifier.java

Violation Line
An operation on an Immutable object (BigDecimal or BigInteger) won't change the object itself 91

org/jaudiotagger/audio/asf/util/TagConverter.java

Violation Line
These nested if statements could be combined 179 - 184

org/jaudiotagger/audio/asf/util/Utils.java

Violation Line
These nested if statements could be combined 65 - 69
These nested if statements could be combined 80 - 82
These nested if statements could be combined 325 - 330
These nested if statements could be combined 439 - 443

org/jaudiotagger/audio/AudioFileIO.java

Violation Line
Avoid unused local variables such as 'it'. 252

org/jaudiotagger/audio/flac/FlacTagWriter.java

Violation Line
Avoid unused private fields such as 'reader'. 48

org/jaudiotagger/audio/generic/AbstractTag.java

Violation Line
Avoid unused local variables such as 'removed'. 394

org/jaudiotagger/audio/generic/AudioFileWriter.java

Violation Line
These nested if statements could be combined 170 - 176
These nested if statements could be combined 545 - 551

org/jaudiotagger/audio/generic/ModificationHandler.java

Violation Line
Avoid unused imports such as 'java.util.Enumeration' 25

org/jaudiotagger/audio/mp3/ByteArrayMP3AudioHeader.java

Violation Line
Avoid empty catch blocks 36 - 40
Avoid empty catch blocks 61 - 65

org/jaudiotagger/audio/mp3/MP3AudioHeader.java

Violation Line
Avoid empty catch blocks 219 - 223
Avoid empty catch blocks 237 - 241
Avoid empty catch blocks 262 - 266
These nested if statements could be combined 479 - 485
These nested if statements could be combined 481 - 484

org/jaudiotagger/audio/mp3/MP3File.java

Violation Line
Avoid unused private methods such as 'readLyrics3Tag(File,RandomAccessFile,int)'. 256
Avoid unused method parameters such as 'loadOptions'. 256 - 279
Avoid unused method parameters such as 'file'. 256 - 279
Avoid unused method parameters such as 'newFile'. 256 - 279
These nested if statements could be combined 798 - 801

org/jaudiotagger/audio/mp3/VbriFrame.java

Violation Line
Avoid unused private fields such as 'VBRI_DELAY_BUFFER_SIZE'. 43
Avoid unused private fields such as 'VBRI_QUALITY_BUFFER_SIZE'. 44
Avoid unused private fields such as 'VBRI_TOC_ENTRY_BUFFER_SIZE'. 47
Avoid unused private fields such as 'lameFrame'. 66
Avoid unused local variables such as 'audioSizeEnabled'. 87
Avoid unused local variables such as 'frameCountEnabled'. 98

org/jaudiotagger/audio/mp4/atom/Mp4EsdsBox.java

Violation Line
Avoid unused private fields such as 'SECTION_SIX'. 94
Avoid unused local variables such as 'sectionThreeLength'. 132
Avoid unused local variables such as 'sectionFourLength'. 133
Avoid unused local variables such as 'sectionFiveLength'. 134
Avoid unused local variables such as 'sectionSixLength'. 135

org/jaudiotagger/audio/mp4/atom/Mp4FtypBox.java

Violation Line
Avoid unused private fields such as 'MAJOR_BRAND_POS'. 23
Avoid unused private fields such as 'MAJOR_BRAND_VERSION_POS'. 25
Avoid empty catch blocks 46 - 50
Avoid empty catch blocks 69 - 72

org/jaudiotagger/audio/mp4/atom/Mp4HdlrBox.java

Violation Line
Avoid unused private fields such as 'reserved'. 44
Avoid unused private fields such as 'name'. 46
Avoid empty catch blocks 83 - 87

org/jaudiotagger/audio/mp4/atom/Mp4MdhdBox.java

Violation Line
Avoid unused local variables such as 'timeLength'. 48

org/jaudiotagger/audio/mp4/atom/Mp4StcoBox.java

Violation Line
Avoid unused local variables such as 'mvhd'. 172
Avoid unused local variables such as 'endOfFirstTrackInBuffer'. 177

org/jaudiotagger/audio/mp4/atom/NullPadding.java

Violation Line
Avoid unused imports such as 'java.nio.ByteBuffer' 3

org/jaudiotagger/audio/mp4/Mp4AtomTree.java

Violation Line
These nested if statements could be combined 320 - 323

org/jaudiotagger/audio/mp4/Mp4InfoReader.java

Violation Line
Avoid unused local variables such as 'atomTree'. 317

org/jaudiotagger/audio/mp4/Mp4TagWriter.java

Violation Line
Avoid unused private methods such as 'createMetadataAtoms(Mp4BoxHeader,ByteBuffer,int,Mp4BoxHeader,Mp4BoxHeader)'. 152 - 157
Avoid unused method parameters such as 'udtaHeader'. 152 - 162
Avoid unused method parameters such as 'metaHeader'. 152 - 162
Avoid unused method parameters such as 'moovBuffer'. 152 - 162
Avoid unused local variables such as 'boxHeader'. 187
Avoid unused local variables such as 'level1SearchPosition'. 197
Avoid unused local variables such as 'hdlrMdiaHeader'. 224
These nested if statements could be combined 539 - 542
These nested if statements could be combined 576 - 579

org/jaudiotagger/audio/ogg/OggFileReader.java

Violation Line
Avoid unused local variables such as 'fix1'. 55

org/jaudiotagger/audio/ogg/OggVorbisTagReader.java

Violation Line
Avoid unused local variables such as 'fix1'. 59

org/jaudiotagger/audio/ogg/util/OggPageHeader.java

Violation Line
Avoid unused local variables such as 'pageSegments'. 185
These nested if statements could be combined 208 - 212

org/jaudiotagger/audio/real/RealFileReader.java

Violation Line
Avoid unused local variables such as 'maxPacketSize'. 32
Avoid unused local variables such as 'avgPacketSize'. 33
Avoid unused local variables such as 'packetCnt'. 34
Avoid unused local variables such as 'preroll'. 36
Avoid unused local variables such as 'indexOffset'. 37
Avoid unused local variables such as 'dataOffset'. 38
Avoid unused local variables such as 'numStreams'. 39
Avoid unused local variables such as 'flags'. 40
Avoid unused local variables such as 'rmf'. 50
Avoid unused local variables such as 'rmf'. 57
Avoid unused local variables such as 'prop'. 58

org/jaudiotagger/audio/wav/WavFileReader.java

Violation Line
Avoid unused imports such as 'org.jaudiotagger.audio.generic.GenericTag' 24

org/jaudiotagger/fix/Fix202.java

Violation Line
No need to import a type that lives in the same package 5
Avoid unused local variables such as 'test'. 18
Avoid unused local variables such as 'audioFile'. 54
Avoid empty catch blocks 61 - 64

org/jaudiotagger/logging/LogFormatter.java

Violation Line
Avoid unused private fields such as 'isObsfucated'. 20
Unnecessary final modifier in final class 36 - 80
Avoid empty catch blocks 75 - 77

org/jaudiotagger/logging/XMLTagDisplayFormatter.java

Violation Line
Avoid unused private fields such as 'formatter'. 34

org/jaudiotagger/tag/asf/AbstractAsfTagImageField.java

Violation Line
No need to import a type that lives in the same package 4
No need to import a type that lives in the same package 5

org/jaudiotagger/tag/asf/AsfTag.java

Violation Line
No need to import a type that lives in the same package 4
No need to import a type that lives in the same package 5
No need to import a type that lives in the same package 6
No need to import a type that lives in the same package 10

org/jaudiotagger/tag/asf/AsfTagBannerField.java

Violation Line
No need to import a type that lives in the same package 7
No need to import a type that lives in the same package 8

org/jaudiotagger/tag/asf/AsfTagCoverField.java

Violation Line
No need to import a type that lives in the same package 7
No need to import a type that lives in the same package 8

org/jaudiotagger/tag/asf/AsfTagField.java

Violation Line
No need to import a type that lives in the same package 23
No need to import a type that lives in the same package 24

org/jaudiotagger/tag/asf/AsfTagTextField.java

Violation Line
No need to import a type that lives in the same package 7
No need to import a type that lives in the same package 8

org/jaudiotagger/tag/datatype/AbstractDataType.java

Violation Line
Ensure you override both equals() and hashCode() 268

org/jaudiotagger/tag/datatype/BooleanByte.java

Violation Line
Ensure you override both equals() and hashCode() 84

org/jaudiotagger/tag/datatype/BooleanString.java

Violation Line
Ensure you override both equals() and hashCode() 55

org/jaudiotagger/tag/datatype/ByteArraySizeTerminated.java

Violation Line
Ensure you override both equals() and hashCode() 62

org/jaudiotagger/tag/datatype/ID3v2LyricLine.java

Violation Line
Ensure you override both equals() and hashCode() 92

org/jaudiotagger/tag/datatype/Lyrics3Image.java

Violation Line
Ensure you override both equals() and hashCode() 135

org/jaudiotagger/tag/datatype/Lyrics3Line.java

Violation Line
Ensure you override both equals() and hashCode() 138

org/jaudiotagger/tag/datatype/Lyrics3TimeStamp.java

Violation Line
Ensure you override both equals() and hashCode() 127

org/jaudiotagger/tag/datatype/MultipleTextEncodedStringNullTerminated.java

Violation Line
Ensure you override both equals() and hashCode() 42

org/jaudiotagger/tag/datatype/NumberFixedLength.java

Violation Line
Ensure you override both equals() and hashCode() 104

org/jaudiotagger/tag/datatype/NumberHashMap.java

Violation Line
Ensure you override both equals() and hashCode() 182

org/jaudiotagger/tag/datatype/NumberVariableLength.java

Violation Line
Ensure you override both equals() and hashCode() 136

org/jaudiotagger/tag/datatype/PartOfSet.java

Violation Line
Ensure you override both equals() and hashCode() 43
These nested if statements could be combined 108 - 114
These nested if statements could be combined 110 - 113
Avoid empty catch blocks 251 - 254
Avoid empty catch blocks 263 - 266

org/jaudiotagger/tag/datatype/StringDate.java

Violation Line
Ensure you override both equals() and hashCode() 76

org/jaudiotagger/tag/datatype/StringDateTime.java

Violation Line
Ensure you override both equals() and hashCode() 76

org/jaudiotagger/tag/datatype/StringFixedLength.java

Violation Line
Ensure you override both equals() and hashCode() 72

org/jaudiotagger/tag/datatype/StringHashMap.java

Violation Line
Ensure you override both equals() and hashCode() 132

org/jaudiotagger/tag/datatype/StringNullTerminated.java

Violation Line
Ensure you override both equals() and hashCode() 52

org/jaudiotagger/tag/datatype/StringSizeTerminated.java

Violation Line
Ensure you override both equals() and hashCode() 59

org/jaudiotagger/tag/datatype/TextEncodedStringNullTerminated.java

Violation Line
Ensure you override both equals() and hashCode() 47
Avoid empty if statements 119 - 122
These nested if statements could be combined 141 - 144

org/jaudiotagger/tag/datatype/TextEncodedStringSizeTerminated.java

Violation Line
Ensure you override both equals() and hashCode() 50
These nested if statements could be combined 116 - 120

org/jaudiotagger/tag/flac/FlacTag.java

Violation Line
Avoid unused imports such as 'org.jaudiotagger.tag.vorbiscomment.VorbisCommentTagField' 12

org/jaudiotagger/tag/id3/AbstractID3v2Tag.java

Violation Line
Avoid unused constructor parameters such as 'copyObject'. 122 - 124
Ensure you override both equals() and hashCode() 699
These nested if statements could be combined 743 - 747
These nested if statements could be combined 1074 - 1077
These nested if statements could be combined 1082 - 1085
These nested if statements could be combined 1102 - 1105
These nested if statements could be combined 1110 - 1113
These nested if statements could be combined 1585 - 1588
These nested if statements could be combined 1614 - 1617
Avoid empty catch blocks 1649 - 1652
Avoid unused local variables such as 'frameid'. 1991

org/jaudiotagger/tag/id3/AbstractTag.java

Violation Line
Ensure you override both equals() and hashCode() 81

org/jaudiotagger/tag/id3/AbstractTagFrame.java

Violation Line
Ensure you override both equals() and hashCode() 115

org/jaudiotagger/tag/id3/AbstractTagFrameBody.java

Violation Line
These nested if statements could be combined 256 - 259
Ensure you override both equals() and hashCode() 274

org/jaudiotagger/tag/id3/AbstractTagItem.java

Violation Line
Avoid unused constructor parameters such as 'copyObject'. 52 - 55
Ensure you override both equals() and hashCode() 99

org/jaudiotagger/tag/id3/framebody/AbstractID3v2FrameBody.java

Violation Line
Ensure you override both equals() and hashCode() 131

org/jaudiotagger/tag/id3/framebody/FrameBodyDeprecated.java

Violation Line
Ensure you override both equals() and hashCode() 60

org/jaudiotagger/tag/id3/framebody/FrameBodyRVAD.java

Violation Line
Ensure you override both equals() and hashCode() 91

org/jaudiotagger/tag/id3/framebody/FrameBodyTDRC.java

Violation Line
Avoid empty catch blocks 283 - 286
Avoid empty catch blocks 324 - 327

org/jaudiotagger/tag/id3/framebody/FrameBodyUnsupported.java

Violation Line
Ensure you override both equals() and hashCode() 128

org/jaudiotagger/tag/id3/ID3Tags.java

Violation Line
These nested if statements could be combined 285 - 288

org/jaudiotagger/tag/id3/ID3Unsynchronization.java

Violation Line
These nested if statements could be combined 72 - 96
These nested if statements could be combined 131 - 140

org/jaudiotagger/tag/id3/ID3v11Tag.java

Violation Line
These nested if statements could be combined 374 - 377
Ensure you override both equals() and hashCode() 416

org/jaudiotagger/tag/id3/ID3v1Tag.java

Violation Line
These nested if statements could be combined 573 - 576
Ensure you override both equals() and hashCode() 804

org/jaudiotagger/tag/id3/ID3v22Frame.java

Violation Line
Avoid empty if statements 85 - 87

org/jaudiotagger/tag/id3/ID3v22Tag.java

Violation Line
Ensure you override both equals() and hashCode() 240
Avoid unused local variables such as 'flags'. 285

org/jaudiotagger/tag/id3/ID3v23Frame.java

Violation Line
Ensure you override both equals() and hashCode() 283

org/jaudiotagger/tag/id3/ID3v23Tag.java

Violation Line
Ensure you override both equals() and hashCode() 352
Avoid unused local variables such as 'flags'. 389

org/jaudiotagger/tag/id3/ID3v24Frame.java

Violation Line
Avoid empty if statements 225 - 227
Ensure you override both equals() and hashCode() 313
Avoid empty if statements 441 - 443
Avoid empty if statements 445 - 448
Avoid empty if statements 491 - 492
Avoid empty if statements 507 - 508

org/jaudiotagger/tag/id3/ID3v24Tag.java

Violation Line
Ensure you override both equals() and hashCode() 649
Avoid unused method parameters such as 'size'. 774 - 831

org/jaudiotagger/tag/lyrics3/AbstractLyrics3.java

Violation Line
Avoid unused local variables such as 'filePointer'. 49
Avoid unused local variables such as 'id3v1tag'. 50

org/jaudiotagger/tag/lyrics3/FieldFrameBodyIMG.java

Violation Line
Ensure you override both equals() and hashCode() 170

org/jaudiotagger/tag/lyrics3/FieldFrameBodyLYR.java

Violation Line
Ensure you override both equals() and hashCode() 228

org/jaudiotagger/tag/lyrics3/FieldFrameBodyUnsupported.java

Violation Line
Ensure you override both equals() and hashCode() 107

org/jaudiotagger/tag/lyrics3/Lyrics3v1.java

Violation Line
Ensure you override both equals() and hashCode() 148

org/jaudiotagger/tag/lyrics3/Lyrics3v2.java

Violation Line
Avoid empty catch blocks 111 - 114
Ensure you override both equals() and hashCode() 199
Avoid unused local variables such as 'filePointer'. 245
Avoid empty catch blocks 273 - 276
Avoid empty if statements 443 - 447
Avoid unused method parameters such as 'byteBuffer'. 487 - 529

org/jaudiotagger/tag/lyrics3/Lyrics3v2Field.java

Violation Line
Avoid unused local variables such as 'filePointer'. 171

org/jaudiotagger/tag/mp4/field/Mp4DiscNoField.java

Violation Line
Avoid unused private fields such as 'NONE_VALUE_INDEX'. 24

org/jaudiotagger/tag/mp4/field/Mp4FieldType.java

Violation Line
Avoid unused imports such as 'org.jaudiotagger.tag.mp4.Mp4FieldKey' 3

org/jaudiotagger/tag/mp4/field/Mp4GenreField.java

Violation Line
Avoid empty catch blocks 42 - 45
These nested if statements could be combined 51 - 54
Avoid empty catch blocks 83 - 86
These nested if statements could be combined 92 - 97

org/jaudiotagger/tag/mp4/field/Mp4TagCoverField.java

Violation Line
Avoid unused imports such as 'org.jaudiotagger.tag.reference.PictureTypes' 25

org/jaudiotagger/tag/mp4/field/Mp4TrackField.java

Violation Line
Avoid unused private fields such as 'NONE_VALUE_INDEX'. 25
Avoid unused private fields such as 'NONE_END_VALUE_INDEX'. 28

org/jaudiotagger/tag/mp4/Mp4TagCreator.java

Violation Line
Avoid empty if statements 94 - 96

org/jaudiotagger/tag/reference/MusicalKey.java

Violation Line
These nested if statements could be combined 67 - 70
These nested if statements could be combined 80 - 83
These nested if statements could be combined 88 - 91

org/jaudiotagger/tag/vorbiscomment/VorbisCommentCreator.java

Violation Line
Avoid empty if statements 68 - 70

org/jaudiotagger/tag/vorbiscomment/VorbisCommentFieldKey.java

Violation Line
Avoid unused imports such as 'org.jaudiotagger.tag.mp4.field.Mp4FieldType' 4
Avoid unused imports such as 'java.util.List' 6

org/jaudiotagger/tag/vorbiscomment/VorbisCommentReader.java

Violation Line
These nested if statements could be combined 149 - 152

org/jaudiotagger/tag/vorbiscomment/VorbisCommentTag.java

Violation Line
Avoid unused imports such as 'org.jaudiotagger.tag.vorbiscomment.VorbisCommentFieldKey.ALBUM' 29

org/jaudiotagger/Test.java

Violation Line
Avoid unused local variables such as 'test2'. 19

org/jaudiotagger/test/ExtractID3TagFromFile.java

Violation Line
Avoid unused local variables such as 'test'. 16
Unnecessary final modifier in final class 83 - 86
Unnecessary final modifier in final class 93 - 96

org/jaudiotagger/test/MergeID3AndMP3Files.java

Violation Line
Unnecessary final modifier in final class 147 - 150
Unnecessary final modifier in final class 157 - 160
Unnecessary final modifier in final class 179 - 182
Avoid unused local variables such as 'result'. 190

org/jaudiotagger/test/TestAudioTagger.java

Violation Line
Unnecessary final modifier in final class 130 - 133